[libc-commits] [PATCH] D93457: [libc] Align src buffer instead of dst buffer

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

In D93457#2481596 <https://reviews.llvm.org/D93457#2481596>, @avieira wrote:

> Hi Guillaume,
>
> Sorry for the late reply, I was looking at some other things and then holidays happened. I started looking at making some changes to CopyAlignedBlocks just like we discussed earlier. One of them is this one and I noticed this makes the MemcpyUtilsTest.CopyAlignedBlocks fail in libc_string_unittests. Specifically the ones that test destination misalignment. It seems the testing infrastructure keeps track of what bytes were read and written. I checked and making the source the misaligned input and switching the read and written expected traces makes it passs. Which makes sense I guess.
>
> Would be good to make the change at the same time though.

Thx for noticing, it should be good now. I'll move you back to reviewers if you don't mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93457/new/

https://reviews.llvm.org/D93457