[libc-commits] [PATCH] D94018: [libc] Add implementation of fmaf.

Cheng Wang via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jan 5 02:54:31 PST 2021


cheng.w added inline comments.


================
Comment at: libc/test/src/math/FmaTest.h:1
+//===-- Utility class to test different flavors of fma  -------------------===//
+//
----------------
Nit: Maybe replace the second space after `fma` with -.


================
Comment at: libc/test/src/math/fmaf_test.cpp:1
+//===-- Unittests for fmaf  -----------------------------------------------===//
+//
----------------
Nit: Maybe replace the second space after `fmaf` with -.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.h:60
 
+  // Operations wich take three floating point nubmers of the same type as
+  // input and produce a single floating point number of the same type as
----------------
Nit: maybe "Operations which take ..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94018/new/

https://reviews.llvm.org/D94018



More information about the libc-commits mailing list