[libc-commits] [PATCH] D97363: [libc][NFC] Remove headergen for the cacheline size macro.

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Feb 24 00:34:09 PST 2021


gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/string/memory_utils/utils.h:9
 
-#ifndef LLVM_LIBC_SRC_MEMORY_UTILS_H
-#define LLVM_LIBC_SRC_MEMORY_UTILS_H
+#ifndef LLVM_LIBC_SRC_MEMORY_UTILS_UTILS_H
+#define LLVM_LIBC_SRC_MEMORY_UTILS_UTILS_H
----------------
Thx for the fix here.


================
Comment at: libc/src/string/memory_utils/utils.h:26
+#define LLVM_LIBC_CACHELINE_SIZE 64
+#endif
 
----------------
Shall we add a supplementary else clause with an `#error "unsupported platform"` directive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97363/new/

https://reviews.llvm.org/D97363



More information about the libc-commits mailing list