[libc-commits] [PATCH] D116178: [libc][obvious] fix formatting mistake

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Dec 22 11:26:24 PST 2021


michaelrj created this revision.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added a project: libc-project.
michaelrj requested review of this revision.

I missed two instances of "SetUp" being replaced by "set_up" and
"TearDown" being replaced by "tear_down" when finalizing the formatting
change. This fixes that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116178

Files:
  libc/benchmarks/LibcBenchmarkTest.cpp
  libc/test/src/signal/sigprocmask_test.cpp


Index: libc/test/src/signal/sigprocmask_test.cpp
===================================================================
--- libc/test/src/signal/sigprocmask_test.cpp
+++ libc/test/src/signal/sigprocmask_test.cpp
@@ -21,9 +21,9 @@
   sigset_t oldSet;
 
 public:
-  void set_up() override { __llvm_libc::sigprocmask(0, nullptr, &oldSet); }
+  void SetUp() override { __llvm_libc::sigprocmask(0, nullptr, &oldSet); }
 
-  void tear_down() override {
+  void TearDown() override {
     __llvm_libc::sigprocmask(SIG_SETMASK, &oldSet, nullptr);
   }
 };
Index: libc/benchmarks/LibcBenchmarkTest.cpp
===================================================================
--- libc/benchmarks/LibcBenchmarkTest.cpp
+++ libc/benchmarks/LibcBenchmarkTest.cpp
@@ -50,9 +50,9 @@
   }
 
 protected:
-  void set_up() override { Options.Log = BenchmarkLog::Full; }
+  void SetUp() override { Options.Log = BenchmarkLog::Full; }
 
-  void tear_down() override {
+  void TearDown() override {
     // We make sure all the expected measurements were performed.
     if (MaybeTimepoints)
       EXPECT_THAT(*MaybeTimepoints, IsEmpty());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116178.395908.patch
Type: text/x-patch
Size: 1111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20211222/d791ee0b/attachment.bin>


More information about the libc-commits mailing list