[libc-commits] [PATCH] D116122: [libc] Add performance tests for hypotf and hypot.

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with some formatting nits



================
Comment at: libc/test/src/math/differential_testing/BinaryOpSingleOutputDiff.h:20
+  static constexpr UIntType MSBit = UIntType(1) << (8 * sizeof(UIntType) - 1);
+  static constexpr UIntType UIntMax = (MSBit - 1) + MSBit;
+
----------------
Constexpr variables should be UPPER_CASE


================
Comment at: libc/test/src/math/differential_testing/BinaryOpSingleOutputDiff.h:51
+
+    double myAverage = static_cast<double>(timer.nanoseconds()) / N;
+    log << "-- My function --\n";
----------------
Normal variables should be lower_case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116122/new/

https://reviews.llvm.org/D116122