[libc-commits] [PATCH] D115408: [libc] Implement correctly rounded logf based on RLIBM library.
Christoph Lauter via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Dec 17 12:23:14 PST 2021
cqlauter added inline comments.
Comment at: libc/src/math/generic/logf.cpp:173
+ FPBits f(xbits.val);
+ f.bits &= ~0x0000'FFFF;
Overall, I think that there should be way more comments for math functions like this one. A line like the one I am highlighting is so hard to understand, even when you are working on that code. Imagine you open up the code in 5 years and need to reunderstand a line like this.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits