[libc-commits] [PATCH] D115408: [libc] Implement correctly rounded logf based on RLIBM library.

[Christoph Lauter via Phabricator via libc-commits]

cqlauter added inline comments.


================
Comment at: libc/src/math/generic/logf.cpp:173
+  FPBits f(xbits.val);
+  f.bits &= ~0x0000'FFFF;
+
----------------
Overall, I think that there should be way more comments for math functions like this one. A line like the one I am highlighting is so hard to understand, even when you are working on that code. Imagine you open up the code in 5 years and need to reunderstand a line like this.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115408/new/

https://reviews.llvm.org/D115408