[libc-commits] [libc] 2cf203d - [libc] Disable signal.h API and its users.

[Siva Chandra Reddy via libc-commits]

Author: Siva Chandra Reddy
Date: 2021-12-16T05:52:28Z
New Revision: 2cf203d9f6cd3ca5b369b06e2124d56eb66f086d

URL: https://github.com/llvm/llvm-project/commit/2cf203d9f6cd3ca5b369b06e2124d56eb66f086d
DIFF: https://github.com/llvm/llvm-project/commit/2cf203d9f6cd3ca5b369b06e2124d56eb66f086d.diff

LOG: [libc] Disable signal.h API and its users.

The signal.h header file from LLVM libc is incorrect. The signal API and
its users will be enabled once signal.h is fixed.

Added: 
    

Modified: 
    libc/config/linux/x86_64/entrypoints.txt
    libc/src/CMakeLists.txt
    libc/src/stdlib/CMakeLists.txt
    libc/test/src/CMakeLists.txt
    libc/test/src/stdlib/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 2e3b453561de0..a7d737e4e80f9 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -185,21 +185,22 @@ set(TARGET_LIBM_ENTRYPOINTS
 if(LLVM_LIBC_FULL_BUILD)
   list(APPEND TARGET_LIBC_ENTRYPOINTS
     # assert.h entrypoints
-    libc.src.assert.__assert_fail
+    # libc.src.assert.__assert_fail
 
     # stdlib.h entrypoints
     libc.src.stdlib._Exit
-    libc.src.stdlib.abort
+    # libc.src.stdlib.abort
 
     # signal.h entrypoints
-    libc.src.signal.raise
-    libc.src.signal.sigaction
-    libc.src.signal.sigdelset
-    libc.src.signal.sigaddset
-    libc.src.signal.sigemptyset
-    libc.src.signal.sigprocmask
-    libc.src.signal.sigfillset
-    libc.src.signal.signal
+    # TODO: Enable signal.h entrypoints after fixing signal.h
+    # libc.src.signal.raise
+    # libc.src.signal.sigaction
+    # libc.src.signal.sigdelset
+    # libc.src.signal.sigaddset
+    # libc.src.signal.sigemptyset
+    # libc.src.signal.sigprocmask
+    # libc.src.signal.sigfillset
+    # libc.src.signal.signal
 
     # sys/mman.h entrypoints
     libc.src.sys.mman.mmap

diff  --git a/libc/src/CMakeLists.txt b/libc/src/CMakeLists.txt
index f13bcc669c59e..006bf5c7563be 100644
--- a/libc/src/CMakeLists.txt
+++ b/libc/src/CMakeLists.txt
@@ -12,8 +12,10 @@ if(NOT LLVM_LIBC_FULL_BUILD)
   return()
 endif()
 
-add_subdirectory(assert)
-add_subdirectory(signal)
+# The signal API is currently disabled as signal.h is incorrect.
+# since assert uses the signal API, we disable assert also.
+# add_subdirectory(assert)
+# add_subdirectory(signal)
 add_subdirectory(stdio)
 # TODO: Add this target conditional to the target OS.
 add_subdirectory(sys)

diff  --git a/libc/src/stdlib/CMakeLists.txt b/libc/src/stdlib/CMakeLists.txt
index 7aeb654fd2d68..773a6d0e995da 100644
--- a/libc/src/stdlib/CMakeLists.txt
+++ b/libc/src/stdlib/CMakeLists.txt
@@ -248,14 +248,14 @@ add_entrypoint_object(
     .${LIBC_TARGET_OS}._Exit
 )
 
-add_entrypoint_object(
-  abort
-  SRCS
-    abort.cpp
-  HDRS
-    abort.h
-  DEPENDS
-    libc.include.stdlib
-    libc.src.signal.raise
-    ._Exit
-)
+# add_entrypoint_object(
+#   abort
+#   SRCS
+#     abort.cpp
+#   HDRS
+#     abort.h
+#   DEPENDS
+#     libc.include.stdlib
+#     libc.src.signal.raise
+#     ._Exit
+# )

diff  --git a/libc/test/src/CMakeLists.txt b/libc/test/src/CMakeLists.txt
index e4f9e49f701f6..d9b184e3790c5 100644
--- a/libc/test/src/CMakeLists.txt
+++ b/libc/test/src/CMakeLists.txt
@@ -38,8 +38,10 @@ if(NOT LLVM_LIBC_FULL_BUILD)
   return()
 endif()
 
-add_subdirectory(assert)
-add_subdirectory(signal)
+# The signal API is currently disabled as signal.h is incorrect.
+# since assert uses the signal API, we disable assert also.
+# add_subdirectory(assert)
+# add_subdirectory(signal)
 add_subdirectory(stdio)
 add_subdirectory(sys)
 add_subdirectory(threads)

diff  --git a/libc/test/src/stdlib/CMakeLists.txt b/libc/test/src/stdlib/CMakeLists.txt
index cd2c081a98feb..8e1948399123a 100644
--- a/libc/test/src/stdlib/CMakeLists.txt
+++ b/libc/test/src/stdlib/CMakeLists.txt
@@ -125,19 +125,19 @@ add_libc_unittest(
     libc.src.stdlib._Exit
 )
 
-add_libc_unittest(
-  abort_test
-  SUITE
-    libc_stdlib_unittests
-  SRCS
-    abort_test.cpp
-  DEPENDS
-    libc.include.stdlib
-    libc.include.signal
-    libc.src.stdlib.abort
-    libc.src.stdlib._Exit
-    libc.src.signal.raise
-)
+# add_libc_unittest(
+#   abort_test
+#   SUITE
+#     libc_stdlib_unittests
+#   SRCS
+#     abort_test.cpp
+#   DEPENDS
+#     libc.include.stdlib
+#     libc.include.signal
+#     libc.src.stdlib.abort
+#     libc.src.stdlib._Exit
+#     libc.src.signal.raise
+# )
 
 add_libc_unittest(
   abs_test