[libc-commits] [PATCH] D115608: [libc] Add documentation about how to add a math function to LLVM-libc.

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits



================
Comment at: libc/src/math/docs/add_math_function.md:45
+```
+- These are preferable to be implemented as header-only.
+- To manipulate bits of floating point numbers, use the template class `__llvm_libc::fputil::FPBits<>` in the header file:
----------------
I think you mean "preferred to be included: as opposed to "preferable to be implemented"


================
Comment at: libc/src/math/docs/add_math_function.md:58
+```
+- Add support for `func` in the `MPFRNumber` class and the corresponding between the enum and its call to the file:
+```
----------------
I think adding the word "link" between "corresponding" and "between" makes the sentence clearer.


================
Comment at: libc/src/math/docs/add_math_function.md:74
+### Exhaustive tests
+- Add exhaustive test to:
+```
----------------
"Add an exhaustive test to:"


================
Comment at: libc/src/math/docs/add_math_function.md:151
+```
\ No newline at end of file

----------------
fix the missing newline at the end of the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115608/new/

https://reviews.llvm.org/D115608