[libc-commits] [PATCH] D115542: [libc] fix memcpy builtin looping

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Dec 10 11:53:11 PST 2021


michaelrj updated this revision to Diff 393562.
michaelrj marked an inline comment as done.
michaelrj added a comment.

remove unnecessary compile options


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115542/new/

https://reviews.llvm.org/D115542

Files:
  libc/cmake/modules/LLVMLibCLibraryRules.cmake
  libc/src/string/memory_utils/elements.h


Index: libc/src/string/memory_utils/elements.h
===================================================================
--- libc/src/string/memory_utils/elements.h
+++ libc/src/string/memory_utils/elements.h
@@ -511,8 +511,6 @@
     // __builtin_memcpy_inline guarantees to never call external functions.
     // Unfortunately it is not widely available.
     __builtin_memcpy_inline(dst, src, SIZE);
-#elif __has_builtin(__builtin_memcpy)
-    __builtin_memcpy(dst, src, SIZE);
 #else
     for_loop_copy(dst, src);
 #endif
Index: libc/cmake/modules/LLVMLibCLibraryRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCLibraryRules.cmake
+++ libc/cmake/modules/LLVMLibCLibraryRules.cmake
@@ -136,7 +136,7 @@
     "ADD_HEADER"
     "" # No optional arguments
     "" # No Single value arguments
-    "HDRS;DEPENDS" # Multi-value arguments
+    "HDRS;DEPENDS;COMPILE_OPTIONS" # Multi-value arguments
     ${ARGN}
   )
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115542.393562.patch
Type: text/x-patch
Size: 970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20211210/a6189299/attachment.bin>


More information about the libc-commits mailing list