[libc-commits] [PATCH] D115408: [libc] Implement correctly rounded logf based on RLIBM library.

[Tue Ly via Phabricator via libc-commits]

lntue marked an inline comment as done.
lntue added a comment.

In D115408#3183323 <https://reviews.llvm.org/D115408#3183323>, @tschuett wrote:

> Do you believe this is a permalink? Maybe cite a paper of the algorithm?

Thanks, I cited the full title of the paper instead.



================
Comment at: libc/src/__support/FPUtil/x86_64/PolyEvalDouble.h:2
+//===-- Common header for PolyEval implementations for x86_64 double -- C++
+//-*-===//
+//
----------------
michaelrj wrote:
> nit: formatting
This file was moved to https://reviews.llvm.org/D115347


================
Comment at: libc/src/__support/FPUtil/x86_64/PolyEvalFloat.h:2
+//===-- Common header for PolyEval implementations for x86_64 float --- C++
+//-*-===//
+//
----------------
michaelrj wrote:
> nit: formatting
This file was moved to https://reviews.llvm.org/D115347


================
Comment at: libc/src/math/generic/logf.cpp:39
+// detail about how this polynomial is obtained, check out the following paper:
+// https://people.cs.rutgers.edu/~sn349/papers/ribmall-popl-2022.pdf
+
----------------
sivachandra wrote:
> s/ribm/rlibm
> 
> Also, seems like this is a yet to be published paper. So, we should update the link when it gets published.
I added the full reference of the paper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115408/new/

https://reviews.llvm.org/D115408