[libc-commits] [PATCH] D115280: [libc] add modified Eisel-Lemire for long doubles

[Michael Jones via Phabricator via libc-commits]

michaelrj marked an inline comment as done.
michaelrj added inline comments.


================
Comment at: libc/src/__support/str_to_float.h:253
+       (fputil::FloatProperties<long double>::MANTISSA_WIDTH + 3));
+  exp2 -= 1 ^ msb; // same as !msb
+
----------------
lntue wrote:
> I'm not sure if I understand the comment here.
`msb` is just the most significant bit of `final_approx_upper` (as assigned on line 248), so `1 ^ msb` is equivalent to `!msb`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115280/new/

https://reviews.llvm.org/D115280