[libc-commits] [PATCH] D114301: [libc] update tidy rules to fix variable formatting

[Michael Jones via Phabricator via libc-commits]

michaelrj marked 2 inline comments as done.
michaelrj added inline comments.


================
Comment at: libc/src/.clang-tidy:3
 HeaderFilterRegex: '.*'
 WarningsAsErrors: 'llvmlibc-*'
 CheckOptions:
----------------
sivachandra wrote:
> michaelrj wrote:
> > sivachandra wrote:
> > > Can we add `readability-*` rules also to this list?
> > not with the patch as it currently is, because in the generated `signal.h` file, the function `sigaction` is being renamed to `__sigaction` by the macro `#define sigaction __sigaction`, which for some reason ignores all of the exceptions I have put in place to handle it. If we rename the struct `__sigaction` to something that the linter doesn't think would be formatted to `sigaction` (e.g. `__sigaction_struct`) then it works fine, but I don't know if that's an acceptable solution.
> I think that can be fixed up as a follow up. You have added the `readability-identifier-naming`, is that something you forgot to take out?
no, that's what enables that specific check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114301/new/

https://reviews.llvm.org/D114301