[libc-commits] [PATCH] D114301: [libc] update tidy rules to fix variable formatting

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/CMakeLists.txt:63
+      Checks: cppcoreguidelines-avoid-goto")
+    endif()
   else()
----------------
Do we still require this?


================
Comment at: libc/src/.clang-tidy:3
 HeaderFilterRegex: '.*'
 WarningsAsErrors: 'llvmlibc-*'
 CheckOptions:
----------------
Can we add `readability-*` rules also to this list?


================
Comment at: libc/src/.clang-tidy:12
+  - key:             readability-identifier-naming.MemberCase
+    value:           aNy_CasE
+  - key:             readability-identifier-naming.VariableCase
----------------
Can you give examples as to why this cannot be `lower_case`?


================
Comment at: libc/src/.clang-tidy:24
+  - key:             readability-identifier-naming.GlobalFunctionIgnoredRegexp
+    value:           "^.+$"
+  - key:             readability-identifier-naming.ConstexprVariableCase
----------------
Do we still need this blanket ignore?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114301/new/

https://reviews.llvm.org/D114301