[libc-commits] [PATCH] D115082: [libc][NFC] refactor math implementations

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet updated this revision to Diff 391751.
gchatelet added a comment.

- Remove commented lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115082/new/

https://reviews.llvm.org/D115082

Files:
  libc/src/math/CMakeLists.txt


Index: libc/src/math/CMakeLists.txt
===================================================================
--- libc/src/math/CMakeLists.txt
+++ libc/src/math/CMakeLists.txt
@@ -1,44 +1,5 @@
 add_subdirectory(internal)
 
-# if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${LIBC_TARGET_ARCHITECTURE})
-#   add_subdirectory(${LIBC_TARGET_ARCHITECTURE})
-# endif()
-
-# function(add_math_entrypoint_object name)
-#   # We prefer machine specific implementation if available. Hence we check
-#   # that first and return early if we are able to add an alias target for the
-#   # machine specific implementation.
-#   get_fq_target_name("${LIBC_TARGET_ARCHITECTURE}.${name}" fq_machine_specific_target_name)
-#   if(TARGET ${fq_machine_specific_target_name})
-#     add_entrypoint_object(
-#       ${name}
-#       ALIAS
-#       DEPENDS
-#         .${LIBC_TARGET_ARCHITECTURE}.${name}
-#     )
-#     return()
-#   endif()
-
-#   get_fq_target_name("generic.${name}" fq_generic_target_name)
-#   if(TARGET ${fq_generic_target_name})
-#     add_entrypoint_object(
-#       ${name}
-#       ALIAS
-#       DEPENDS
-#         .generic.${name}
-#     )
-#     return()
-#   endif()
-
-#   # Add a dummy entrypoint object for missing implementations. They will be skipped
-#   # anyway as there will be no entry for them in the target entrypoints list.
-#   add_entrypoint_object(
-#     ${name}
-#     SRCS dummy_srcs
-#     HDRS dummy_hdrs
-#   )
-# endfunction()
-
 add_entrypoint_object(
   fmaf
   SRCS fmaf.cpp


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115082.391751.patch
Type: text/x-patch
Size: 1495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20211203/b2aa3cdc/attachment-0001.bin>