[libc-commits] [PATCH] D114302: [libc] apply new lint rules

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/math/generic/sincosf_data.cpp:18
 // computes -cos (x) rather than cos (x) to get negation for free.
-const sincos_t __sincosf_table[2] = {
+const sincos_t sincosf_table[2] = {
     {{1.0, -1.0, -1.0, 1.0},
----------------
lntue wrote:
> This constant table is in float, so constexpr won't work.  Is there any simple way to make this all caps?
I solved this by adding an exception for variables starting with underscores, so if you want to have a variable with any case you want, it just has to start with an underscore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114302/new/

https://reviews.llvm.org/D114302