[libc-commits] [PATCH] D114302: [libc] apply new lint rules

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/math/generic/sincosf_data.cpp:18
 // computes -cos (x) rather than cos (x) to get negation for free.
-const sincos_t __sincosf_table[2] = {
+const sincos_t sincosf_table[2] = {
     {{1.0, -1.0, -1.0, 1.0},
----------------
This constant table is in float, so constexpr won't work.  Is there any simple way to make this all caps?


================
Comment at: libc/src/math/generic/sincosf_data.cpp:45
 // only 8 new bits are added per entry, making the table 4 times larger.
-const uint32_t __inv_pio4[24] = {
+const uint32_t inv_pio4[24] = {
     0xa2,       0xa2f9,     0xa2f983,   0xa2f9836e, 0xf9836e4e, 0x836e4e44,
----------------
INV_PIO4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114302/new/

https://reviews.llvm.org/D114302