[libc-commits] [PATCH] D115034: [libc] Select FPUtils implementations via code instead of build

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

In D115034#3169583 <https://reviews.llvm.org/D115034#3169583>, @sivachandra wrote:

> Please wait for lntue as he is also planning some refactoring around `FMA.h`.

Sure!



================
Comment at: libc/src/__support/FPUtil/FEnvImpl.h:15
+#if defined(LLVM_LIBC_ARCH_AARCH64)
+#include "src/__support/FPUtil/aarch64/FEnvImpl.h"
+#elif defined(LLVM_LIBC_ARCH_X86)
----------------
sivachandra wrote:
> Nit: Any reason why prefer full paths instead of relative paths?
Either is fine, I just aimed for consistency. I can do relative everywhere if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115034/new/

https://reviews.llvm.org/D115034