[libc-commits] [PATCH] D108952: [libc][nfc][obvious] fix typos in FPUtil

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Aug 30 15:37:49 PDT 2021


michaelrj created this revision.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added a project: libc-project.
michaelrj requested review of this revision.

Fix minor typos in FPUtil comments.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108952

Files:
  libc/src/__support/FPUtil/FMA.h
  libc/src/__support/FPUtil/Sqrt.h
  libc/src/__support/FPUtil/generic/README.md


Index: libc/src/__support/FPUtil/generic/README.md
===================================================================
--- libc/src/__support/FPUtil/generic/README.md
+++ libc/src/__support/FPUtil/generic/README.md
@@ -4,7 +4,7 @@
 implementations from machine dependent implementations. Consider the example of
 the fuse-multiply-add operation (FMA). The C standard library requires three
 different flavors, `fma` which operates double precsion numbers, `fmaf` which
-operates on single precision numbers, and `fmal` which operates on `lond double`
+operates on single precision numbers, and `fmal` which operates on `long double`
 numbers. On Aarch64, there are hardware instructions which implement the single
 and double precision flavors but not the `long double` flavor. For such targets,
 we want to be able to call the generic `long double` implementation from the
Index: libc/src/__support/FPUtil/Sqrt.h
===================================================================
--- libc/src/__support/FPUtil/Sqrt.h
+++ libc/src/__support/FPUtil/Sqrt.h
@@ -121,7 +121,7 @@
     int xExp = bits.getExponent();
     UIntType xMant = bits.getMantissa();
 
-    // Step 1a: Normalize denormal input and append hiddent bit to the mantissa
+    // Step 1a: Normalize denormal input and append hidden bit to the mantissa
     if (bits.getUnbiasedExponent() == 0) {
       ++xExp; // let xExp be the correct exponent of One bit.
       internal::normalize<T>(xExp, xMant);
Index: libc/src/__support/FPUtil/FMA.h
===================================================================
--- libc/src/__support/FPUtil/FMA.h
+++ libc/src/__support/FPUtil/FMA.h
@@ -21,7 +21,7 @@
 namespace __llvm_libc {
 namespace fputil {
 
-// We have a generic implementation available only for single precision fma os
+// We have a generic implementation available only for single precision fma as
 // we restrict it to float values for now.
 template <typename T>
 static inline cpp::EnableIfType<cpp::IsSame<T, float>::Value, T> fma(T x, T y,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108952.369563.patch
Type: text/x-patch
Size: 2019 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20210830/958fffab/attachment.bin>


More information about the libc-commits mailing list