[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/lib/CMakeLists.txt:5
+  include(../../compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake)
+  if(NOT (LIBC_TARGET_ARCHITECTURE IN_LIST ALL_SCUDO_STANDALONE_SUPPORTED_ARCH))
+    message(FATAL_ERROR "Architecture ${LIBC_TARGET_ARCHITECTURE} is not supported by SCUDO. 
----------------
sivachandra wrote:
> I think this check and the GWP-ASan check below are best effort checks. For, it can so happen that the SCUDO and GWP-ASan object libraries might not be available while satisfying this check. Am I right?
Correct. If compiler-rt and llvm libc are set to compile to different architectures then there will be an error here, but hopefully that won't be a problem in the real world.


================
Comment at: libc/test/integration/scudo/gwp_asan_should_crash.cpp:22
+    volatile char x = *Ptr;
+    retval = retval + x;
+  }
----------------
hctim wrote:
> is this necessary?
yes, because otherwise the compiler warns about x being an unused variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919