[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/lib/CMakeLists.txt:5
+  include(../../compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake)
+  if(NOT (LIBC_TARGET_ARCHITECTURE IN_LIST ALL_SCUDO_STANDALONE_SUPPORTED_ARCH))
+    message(FATAL_ERROR "Architecture ${LIBC_TARGET_ARCHITECTURE} is not supported by SCUDO. 
----------------
I think this check and the GWP-ASan check below are best effort checks. For, it can so happen that the SCUDO and GWP-ASan object libraries might not be available while satisfying this check. Am I right?


================
Comment at: libc/test/integration/scudo/CMakeLists.txt:26
+)
\ No newline at end of file

----------------
sivachandra wrote:
> Fix.
This showed up again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919