[libc-commits] [PATCH] D108845: [libc][NFC] Fix onre more -Wconversion warning in strtoul test code.

Roland McGrath via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Aug 27 14:13:14 PDT 2021


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG225eb8a22d41: [libc][NFC] Fix onre more -Wconversion warning in strtoul test code. (authored by mcgrathr).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108845/new/

https://reviews.llvm.org/D108845

Files:
  libc/test/src/stdlib/strtoul_test.cpp


Index: libc/test/src/stdlib/strtoul_test.cpp
===================================================================
--- libc/test/src/stdlib/strtoul_test.cpp
+++ libc/test/src/stdlib/strtoul_test.cpp
@@ -227,7 +227,7 @@
             } else {
               errno = 0;
               ASSERT_EQ(__llvm_libc::strtoul(small_string, nullptr, base),
-                        first_digit);
+                        static_cast<unsigned long int>(first_digit));
               ASSERT_EQ(errno, 0);
             }
           } else {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108845.369184.patch
Type: text/x-patch
Size: 522 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20210827/03a20e58/attachment.bin>


More information about the libc-commits mailing list