[libc-commits] [PATCH] D108591: [libc] fix string conversion tests for windows

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/stdlib/strtol_test.cpp:30
   ASSERT_EQ(errno, 0);
-  EXPECT_EQ(str_end - ten, 2l);
+  EXPECT_EQ(static_cast<long long>(str_end - ten), 2ll);
+
----------------
I think a more appropriate way to do these comparisons would be:

```
EXPECT_EQ(str_end - ten, ptrdiff_t(2));
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108591/new/

https://reviews.llvm.org/D108591