[libc-commits] [PATCH] D107987: [libc][nfc] add CPP Limits.h for numeric_limits

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/utils/CPP/Limits.h:15
+
+#include <limits.h>
+
----------------
Move this outside of the namespace?


================
Comment at: libc/utils/CPP/Limits.h:17
+
+template <class T> class numeric_limits {
+public:
----------------
Name the class `NumericLimits` to follow the convention of the rest of CPP utils.


================
Comment at: libc/utils/CPP/Limits.h:19
+public:
+  static T max();
+  static T min();
----------------
Make these static methods `constexpr` also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107987/new/

https://reviews.llvm.org/D107987