[libc-commits] [PATCH] D107792: [libc] add strtoll function and backend

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 11 10:57:14 PDT 2021


michaelrj marked an inline comment as done.
michaelrj added inline comments.


================
Comment at: libc/src/__support/str_conv_utils.h:13
+#include "src/__support/ctype_utils.h"
+#include "src/errno/llvmlibc_errno.h"
+#include <errno.h>
----------------
sivachandra wrote:
> You don't need this. In the code below, use `errno` directly. `llvmlibc_errno.h` is not available in the default build.
Done, but I had to change all the tests to match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107792/new/

https://reviews.llvm.org/D107792



More information about the libc-commits mailing list