[libc-commits] [PATCH] D101609: [libc] warns about missing linting only in full build mode

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

LGTM with one additional suggestion.



================
Comment at: libc/CMakeLists.txt:47
+
 option(LLVM_LIBC_ENABLE_LINTING "Enables linting of libc source files" OFF)
 if(LLVM_LIBC_ENABLE_LINTING)
----------------
May be add something like this below this line:

```
if(LLVM_LIBC_ENABLE_LINTING AND (NOT LLVM_LIBC_FULL_BUILD))
  message(FATAL_ERROR "Cannot enable linting when full libc build is not enabled.")
endif()
```

Linting, as implemented currently, is meaningless when not using LLVM libc headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101609/new/

https://reviews.llvm.org/D101609