[libc-commits] [PATCH] D101528: [libc] Fix linting for string functions
Guillaume Chatelet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Apr 29 11:36:21 PDT 2021
gchatelet added a comment.
In D101528#2725859 <https://reviews.llvm.org/D101528#2725859>, @sivachandra wrote:
> Mixed build - You only pick those parts from LLVM libc which you are interested in and get the rest from the system libc. In this mode, we don't use headers from LLVM libc.
> Full build - This mode behaves as if LLVM libc is the only libc. So, we want to ensure that the libc build does not get mixed up with headers from the system libc. The lint step helps us with this.
> In mixed build mode, CMake should not warn you about linting at all. Will send a fix soon.
Thx for the explanation, I never triggered full build (AFAIU you need to pass `-DLLVM_LIBC_FULL_BUILD=ON`) I ran into these errors by running `check-libc` or `libc_string_unittests`.
I think it's only a matter of disabling the warning (`llvm-project/libc/CMakeLists.txt:61`) when not in full build mode then.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits