[libc-commits] [PATCH] D101528: [libc] Fix linting for string functions

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

In D101528#2725815 <https://reviews.llvm.org/D101528#2725815>, @sivachandra wrote:

> Ah, you are probably doing a mixed build with linting enabled. I think that is a bug in the CMake logic. It should not allow you to switch on linting in mixed build mode (mixed build mode is the default mode). Linting should be on only in full build mode.
> FWIW, we have full build builders on the public buildbot which build with linting enabled. Example: https://lab.llvm.org/buildbot/#/builders/163

What do you mean exactly by "mixed build"?

When I compile I can see this message:

  -- Set COMPILER_RESOURCE_DIR to /usr/local/google/home/gchatelet/build-llvm/download/clang/lib/clang/13.0.0 using --print-resource-dir
  CMake Warning at /usr/local/google/home/gchatelet/git/llvm-project/libc/CMakeLists.txt:61 (message):
    
  
        Linting for libc is currently disabled.
  
    
  
        This is not recommended, to enable set LLVM_LIBC_ENABLE_LINTING to ON
        (pass -DLLVM_LIBC_ENABLE_LINTING=ON to cmake).

Which I why I enabled `-DLLVM_LIBC_ENABLE_LINTING=ON` and then I started to get the errors, and then I tried to fix them :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101528/new/

https://reviews.llvm.org/D101528