[libc-commits] [PATCH] D101528: [libc] Fix linting for string functions

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Apr 29 08:35:35 PDT 2021

sivachandra added a comment.

Can you share what linting errors you are getting? The include order is setup so that when doing a full build, the build picks up LLVM libc's header files and does not lead to lint errors. If you are seeing lint errors, it could imply that `DEPS` in the CMake targets are incomplete. The includes for `<math.h>` and `<fenv.h>` are as they are to keep the mixed builds working.

Also, we want to include `<public_header.h>` is all implementation headers because of the reason explained here: https://reviews.llvm.org/D94195#inline-881934. We don't do it currently -- because no one has done the cleanup! Also, there is potential for strange errors elsewhere in pieces which cannot be part of a mixed build.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list