[libc-commits] [PATCH] D101524: [libc] Normalize LIBC_TARGET_MACHINE

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Apr 29 05:23:15 PDT 2021


gchatelet created this revision.
gchatelet added a reviewer: sivachandra.
Herald added subscribers: libc-commits, ecnelises, tschuett, pengfei, kristof.beyls, mgorny.
Herald added a project: libc-project.
gchatelet requested review of this revision.

Current implementation defines LIBC_TARGET_MACHINE with the use of CMAKE_SYSTEM_PROCESSOR.
Unfortunately CMAKE_SYSTEM_PROCESSOR is OS dependent and can produce different results.
An evidence of this is the various matchers used to detect whether the architecture is x86.

This patch normalizes LIBC_TARGET_MACHINE and renames it LIBC_TARGET_ARCHITECTURE.
I've added many architectures but we may want to limit ourselves to x86 and ARM.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101524

Files:
  libc/CMakeLists.txt
  libc/cmake/modules/LLVMLibCArchitectures.cmake
  libc/cmake/modules/LLVMLibCCheckCpuFeatures.cmake
  libc/config/linux/CMakeLists.txt
  libc/fuzzing/CMakeLists.txt
  libc/loader/linux/CMakeLists.txt
  libc/src/math/CMakeLists.txt
  libc/src/string/CMakeLists.txt
  libc/src/string/aarch64/CMakeLists.txt
  libc/src/string/x86/CMakeLists.txt
  libc/src/string/x86/memcpy.cpp
  libc/src/string/x86_64/CMakeLists.txt
  libc/src/string/x86_64/memcpy.cpp
  libc/src/threads/linux/CMakeLists.txt
  libc/test/config/linux/CMakeLists.txt
  libc/test/loader/linux/CMakeLists.txt
  libc/test/src/math/CMakeLists.txt
  libc/test/utils/FPUtil/CMakeLists.txt
  libc/utils/FPUtil/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101524.341480.patch
Type: text/x-patch
Size: 17609 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20210429/9bb66f31/attachment-0001.bin>


More information about the libc-commits mailing list