[libc-commits] [PATCH] D100732: [libc] Enhance ArrayRef + unittests

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet marked 3 inline comments as done.
gchatelet added inline comments.


================
Comment at: libc/utils/CPP/ArrayRef.h:90
+  // equals - Check for element-wise equality.
+  bool equals(ArrayRefBase<QualifiedT> RHS) const {
+    if (Length != RHS.Length)
----------------
sivachandra wrote:
> Calling it `equals` is a bit misleading when we are comparing references. Unless this name is inspired from other places in llvm-project, may be name it `equalData` or something like that?
I agree it's not ideal but I tried to stick to the llvm's [ArrayRef](https://llvm.org/doxygen/classllvm_1_1ArrayRef.html#a21ff1fd12b25b79fcd4449c35dc814b6) naming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100732/new/

https://reviews.llvm.org/D100732