[libc-commits] [PATCH] D100631: [libc] Extends the testing framework to support typed test
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Apr 16 09:27:15 PDT 2021
sivachandra added a comment.
While I am not opposed to this, I want to learn the usefulness of this feature. IIUC, this limits to a single `ParamType` - as in a uni-dimensional type variance. We have examples in math functions where there is two-dimensional type variance. I am not sure the feature added in this patch can help with it. For such cases, have used template test classes and helper macros to list the various combination of tests: https://github.com/llvm/llvm-project/blob/main/libc/test/src/math/RoundToIntegerTest.h.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100631/new/
https://reviews.llvm.org/D100631
More information about the libc-commits
mailing list