[libc-commits] [PATCH] D100569: [libc] Add slice/take/drop methods to ArrayRef

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Apr 16 00:53:51 PDT 2021


gchatelet added inline comments.


================
Comment at: libc/utils/CPP/ArrayRef.h:28
+  using pointer = T *;
+  using reference = T &;
 
----------------
sivachandra wrote:
> These are effectively type names so why not **`C`**`apitalize` them?
This is to follow the naming scheme of STL container
https://en.cppreference.com/w/cpp/container/array


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100569/new/

https://reviews.llvm.org/D100569



More information about the libc-commits mailing list