[libc-commits] [PATCH] D87516: [libc] Add implementation for hypotf

[Hung Dang via Phabricator via libc-commits]

hungptit added inline comments.


================
Comment at: libc/src/math/hypotf.cpp:88
+  if (xBits.isInf() || yBits.isInf()) {
+    return FPBits<float>::inf();
+  } else if (xBits.isNaN()) {
----------------
Shall we use the return early pattern for this if block?


================
Comment at: libc/test/src/math/hypotf_test.cpp:21
+
+static const float zero = FPBits::zero();
+static const float negZero = FPBits::negZero();
----------------
Does const/constexpr work for these global variables?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87516/new/

https://reviews.llvm.org/D87516