[libc-commits] [PATCH] D89436: Update spec information.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/spec/stdc.td:4
+  // Most type definitions are dealt with in spec.td, but FILE (and associated
+  // derivative types) are also defined in libc/config/public_api.td.
+  // This causes a problem if the FILE type is defined in spec.td, so it is left
----------------
michaelrj wrote:
> sivachandra wrote:
> > Can you point to the line in `public_api.td` which has the definitions for `FILE` related types.
> oops, that should say libc/config/[platform]/api.td, and the line is 30: https://github.com/llvm/llvm-project/blob/master/libc/config/linux/api.td#L30. The comment is now updated to reflect that.
Ah! Just remove the comment from here may be. Its more confusing than actually explaining the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89436/new/

https://reviews.llvm.org/D89436