[libc-commits] [PATCH] D89267: Move Cannonical Function List

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

OK after addressing the last set of nits.



================
Comment at: libc/spec/stdc.td:2
 def StdC : StandardSpec<"stdc"> {
+
   ConstType ConstVoidPtr = ConstType<VoidPtr>;
----------------
Remove this edit from this patch.


================
Comment at: libc/utils/HdrGen/Generator.h:34
   llvm::StringRef HeaderDefFile;
+  std::vector<std::string> EntrypointNameList;
   llvm::StringRef StdHeader;
----------------
Make this a const reference:

```
const std::vector<std::string> &EntrypointNameList;
```


================
Comment at: libc/utils/HdrGen/Generator.h:49
+  Generator(const std::string &DefFile,
+            const std::vector<std::string> EntrypointNamesOption,
+            const std::string &Header,
----------------
A const reference argument here as well. Also, instead of `EntrypointNamesOption`, `EN` is OK.


================
Comment at: libc/utils/HdrGen/PublicAPICommand.h:30
+private:
+  std::vector<std::string> EntrypointNameList;
+
----------------
A const reference member here as well?


================
Comment at: libc/utils/HdrGen/PublicAPICommand.h:35
 
+  PublicAPICommand(std::vector<std::string> EntrypointNames)
+      : EntrypointNameList(EntrypointNames) {}
----------------
A const reference argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89267/new/

https://reviews.llvm.org/D89267