[libc-commits] [PATCH] D91551: Initial commit of mktime.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Nov 30 10:26:17 PST 2020


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/time/mktime.cpp:53
+  // overflow value. If not keep accumulating. The benefit is that, we don't
+  // have to validate every input, and also do need the special cases for
+  // sizeof(time_t) == 4".
----------------
Ah, a typo in my comment got carried over here.... "`... also, do NOT need the special cases ...`"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91551/new/

https://reviews.llvm.org/D91551



More information about the libc-commits mailing list