[libc-commits] [PATCH] D91831: [libc] Add implementation of hypot.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/utils/FPUtil/Hypot.h:121
+static inline T hypot(T x, T y) {
+  using FPBits_t = FPBits<T>;
+  using UInt_t = typename FPBits<T>::UIntType;
----------------
In other functions, we have not used the `_t` suffixes. To be consistent, can you follow the same convention here? If you feel strongly about the `_t` style, you can do a follow up cleanup pass changing everything to follow the `_t` style.


================
Comment at: libc/utils/FPUtil/Hypot.h:122
+  using FPBits_t = FPBits<T>;
+  using UInt_t = typename FPBits<T>::UIntType;
+  using DUInt_t = typename DoubleLength<UInt_t>::Type;
----------------
Same here: other places do not have the `_t` but use `UIntType` with the template type.


================
Comment at: libc/utils/FPUtil/Hypot.h:123
+  using UInt_t = typename FPBits<T>::UIntType;
+  using DUInt_t = typename DoubleLength<UInt_t>::Type;
+
----------------
Same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91831/new/

https://reviews.llvm.org/D91831