[libc-commits] [PATCH] D91817: [libc] Combine all math differential fuzzers into one target.

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Nov 19 13:34:46 PST 2020


lntue added inline comments.


================
Comment at: libc/fuzzing/math/SingleInputSingleOutputDiff.h:38
+  if (isinf(result1)) {
+    if (isinf(result2) != isinf(result1))
+      __builtin_trap();
----------------
Why these checks are not  isnan(r1) != isnan(r2)
and isinf(r1) != isinf(r2) ?


================
Comment at: libc/fuzzing/math/TwoInputSingleOutputDiff.h:40
+  if (isinf(result1)) {
+    if (isinf(result2) != isinf(result1))
+      __builtin_trap();
----------------
same comment as SingleInputSingleOutput


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91817/new/

https://reviews.llvm.org/D91817



More information about the libc-commits mailing list