[libc-commits] [PATCH] D91665: [libc] Make more of the libc unit testing llvm independent

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

submit comments



================
Comment at: libc/utils/UnitTest/CMakeLists.txt:5
   Test.h
-  LINK_COMPONENTS Support
 )
----------------
sivachandra wrote:
> You should probably do the same in `utils/testutils/CMakeLists.txt`? I will do another pass and switch these targets to `add_library` after I move FPUtil's `TestHelpers`.
I'll do that once I get the rest of the llvm dependencies out of `utils/testutils` which should be pretty soon after I get this next commit working.


================
Comment at: libc/utils/testutils/ExecuteFunctionUnix.cpp:12
 #include <cstdlib>
+#include <cstring>
+#include <iostream>
----------------
sivachandra wrote:
> Why do we need `cstring`?
because otherwise `strsignal` depends on it (line 81)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91665/new/

https://reviews.llvm.org/D91665