[libc-commits] [PATCH] D91665: [libc] Make more of the libc unit testing llvm independent
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Nov 17 15:49:14 PST 2020
michaelrj created this revision.
michaelrj added a reviewer: sivachandra.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added a project: libc-project.
michaelrj requested review of this revision.
(WIP, hopefully I'll add more to this patch before submitting)
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D91665
Files:
libc/utils/UnitTest/CMakeLists.txt
libc/utils/testutils/ExecuteFunctionUnix.cpp
Index: libc/utils/testutils/ExecuteFunctionUnix.cpp
===================================================================
--- libc/utils/testutils/ExecuteFunctionUnix.cpp
+++ libc/utils/testutils/ExecuteFunctionUnix.cpp
@@ -7,9 +7,10 @@
//===----------------------------------------------------------------------===//
#include "ExecuteFunction.h"
-#include "llvm/Support/raw_ostream.h"
#include <cassert>
#include <cstdlib>
+#include <cstring>
+#include <iostream>
#include <memory>
#include <poll.h>
#include <signal.h>
@@ -41,8 +42,8 @@
return ProcessStatus::Error("pipe(2) failed");
// Don't copy the buffers into the child process and print twice.
- llvm::outs().flush();
- llvm::errs().flush();
+ std::cout.flush();
+ std::cerr.flush();
pid_t Pid = ::fork();
if (Pid == -1)
return ProcessStatus::Error("fork(2) failed");
Index: libc/utils/UnitTest/CMakeLists.txt
===================================================================
--- libc/utils/UnitTest/CMakeLists.txt
+++ libc/utils/UnitTest/CMakeLists.txt
@@ -2,7 +2,6 @@
LibcUnitTest
Test.cpp
Test.h
- LINK_COMPONENTS Support
)
target_include_directories(LibcUnitTest PUBLIC ${LIBC_SOURCE_DIR})
add_dependencies(LibcUnitTest libc.utils.CPP.standalone_cpp)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91665.305915.patch
Type: text/x-patch
Size: 1260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20201117/e31a8f98/attachment.bin>
More information about the libc-commits
mailing list