[libc-commits] [PATCH] D91568: [libc] make part of libc's unit test framework independent of llvm

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D91568#2400565 <https://reviews.llvm.org/D91568#2400565>, @sivachandra wrote:

> In D91568#2400511 <https://reviews.llvm.org/D91568#2400511>, @abrachet wrote:
>
>> The LibcUnitTest <https://github.com/llvm/llvm-project/blob/master/libc/utils/UnitTest/CMakeLists.txt> and libc_test_utils <https://github.com/llvm/llvm-project/blob/master/libc/utils/testutils/CMakeLists.txt#L6> targets are made with `add_llvm_library` and link against `Support`. Presumably we would need use `add_library`, (although it may not be the case that `add_llvm_library` implicitly adds any LLVM dependencies,  I haven't checked).
>>
>> `libc_test_utils` also has a small dependency on `llvm::ostream` and `llvm::MemoryBuffer`. I feel bad just bringing it up without just changing it myself because I think a lot of that code was added by me, but I don't really have time to work on it until after my semester ends, unfortunately.
>
> Ah yes! The build rules slipped my mind. I will take a shot at it.

To be fair though, Michael said he will make another pass and //clean up// the rest of the pieces having LLVM dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91568/new/

https://reviews.llvm.org/D91568