[libc-commits] [PATCH] D91568: [libc] make part of libc's unit test framework independent of llvm
Alex Brachet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Nov 17 11:19:35 PST 2020
abrachet added a comment.
The LibcUnitTest <https://github.com/llvm/llvm-project/blob/master/libc/utils/UnitTest/CMakeLists.txt> and libc_test_utils <https://github.com/llvm/llvm-project/blob/master/libc/utils/testutils/CMakeLists.txt#L6> targets are made with `add_llvm_library` and link against `Support`. Presumably we would need use `add_library`, (although it may not be the case that `add_llvm_library` implicitly adds any LLVM dependencies, I haven't checked).
`libc_test_utils` also has a small dependency on `llvm::ostream` and `llvm::MemoryBuffer`. I feel bad just bringing it up without just changing it myself because I think a lot of that code was added by me, but I don't really have time to work on it until after my semester ends, unfortunately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91568/new/
https://reviews.llvm.org/D91568
More information about the libc-commits
mailing list