[libc-commits] [PATCH] D90985: [libc] Extend WrapperGen to emit aliases.

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

lgtm with nits



================
Comment at: libc/utils/tools/WrapperGen/Main.cpp:65
+    // If not emitting an alias, and not appending to another file,
+    // we should include the implementtion header to ensure the wrapper
+    // compiles.
----------------
nit: implementation


================
Comment at: libc/utils/tools/WrapperGen/Main.cpp:77-78
+    if (!ErrorOrBuf) {
+      llvm::PrintFatalError("Unable to read the file " + AppendToFile +
+                            " to append to.");
+    }
----------------
nit: add single quotes around the filename for clarity


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90985/new/

https://reviews.llvm.org/D90985