[libc-commits] [PATCH] D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Nov 3 12:51:17 PST 2020


sivachandra added inline comments.


================
Comment at: libc/src/assert/assert.h:8
 //===----------------------------------------------------------------------===//
 
+#include "src/assert/__assert_fail.h"
----------------
sivachandra wrote:
> abrachet wrote:
> > sivachandra wrote:
> > > Missing header guard.
> > This is the intended behavior for `assert.h` which can be included multiple times with `NDEBUG` redefined.
> Ah, thanks for reminding. Ignore my comment then.
@michaelrj, can you please add a comment explaining what @abrachet said?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90653/new/

https://reviews.llvm.org/D90653



More information about the libc-commits mailing list