[libc-commits] [PATCH] D74021: Created uChar implementation for libc

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue May 26 23:57:39 PDT 2020


sivachandra added a comment.

In D74021#2051565 <https://reviews.llvm.org/D74021#2051565>, @MarcusJohnson91 wrote:

> Hey guys: @sivachandra.
>
> My clang-format patch landed yesterday so I'm working again on my libc patch to add uchar and maybe wchar stuff.
>
> I've been rewriting c16rtomb and it works a lot better now but I was wondering how we're supposed to handle errors in llvm-libc?


LLVM-libc should do what the standards say. For example, if the standards say that errno has to be set to a certain value to indicate error, then LLVM-libc should do that. Likewise, if standards say that the function in question should return an error value, then LLVM libc should do that.

I can probably give more specific answers if you can point out the particular function you are asking about.

Thanks,
Siva Chandra


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74021/new/

https://reviews.llvm.org/D74021





More information about the libc-commits mailing list