[libc-commits] [PATCH] D79192: [libc] Add integration tests.

Paula Toth via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue May 26 20:42:13 PDT 2020


PaulkaToast added a comment.

In D79192#2048306 <https://reviews.llvm.org/D79192#2048306>, @sivachandra wrote:

> In D79192#2048277 <https://reviews.llvm.org/D79192#2048277>, @PaulkaToast wrote:
>
> > As for the Linux dev headers I think instead of a work around using `clang-tidy`, it might just be better to remove our dependency on the dev headers all together, especially since the dev headers differ between platforms such as `sigset_t` on AARCH64 vs x86.
> >  I can send out a separate patch out for this as well.
>
>
> What do you mean remove the dependency on dev headers? Does it mean that we make copies of linux definitions in LLVM libc tree?


As we discussed offline, the approach I was thinking would involve duplicating a lot of definitions from the linux headers. So I decided to take the approach you suggested and use clang-tidy to ensure we're including the correct headers in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79192/new/

https://reviews.llvm.org/D79192





More information about the libc-commits mailing list