[libc-commits] [PATCH] D80291: [libc][NFC] Simplify memcpy implementation

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.


================
Comment at: libc/src/string/CMakeLists.txt:78
   add_implementation(memcpy ${memcpy_name}
-    SRCS ${LIBC_SOURCE_DIR}/src/string/memcpy.cpp
+    SRCS ${LIBC_SOURCE_DIR}/src/string/${LIBC_STRING_TARGET_FOLDER}/memcpy.cpp
     HDRS ${LIBC_SOURCE_DIR}/src/string/memcpy.h
----------------
abrachet wrote:
> While we're here maybe we could call this `LIBC_STRING_TARGET_DIR`?
> 
> But as a second thought maybe we just call this `LIBC_STRING_TARGET_ARCH`. There are already a few places where we don't care about x86/x86_64. For example in `memory_utils/CMakeLists.txt` we can use the data file as `cacheline_size_${LIBC_STRING_TARGET_ARCH}.h.inc` and not need two identical `cacheline_size` files.
+1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80291/new/

https://reviews.llvm.org/D80291