[libc-commits] [PATCH] D79192: [libc] Add integration tests.

Paula Toth via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed May 20 21:29:40 PDT 2020


PaulkaToast added a comment.
Herald added a subscriber: ecnelises.

Sorry for the delayed response!

I like idea of a `.txt` for both the headers and the entrypoints. This is nice because it also prevents us from building and including platform specific headers e.g `fcntl.h` which is on Linux but not on Windows.
Will send out a revised diff soon. (:

As for the Linux dev headers I think instead of a work around using `clang-tidy`, it might just be better to remove our dependency on the dev headers all together, especially since the dev headers differ between platforms such as `sigset_t` on AARCH64 vs x86.
I can send out a separate patch out for this as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79192/new/

https://reviews.llvm.org/D79192





More information about the libc-commits mailing list