[libc-commits] [PATCH] D79828: [libc] Add implementation of call_once from threads.h.

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat May 16 20:40:40 PDT 2020


abrachet added a comment.
Herald added a subscriber: ecnelises.

This looks good to me but it might be worth waiting for @MaskRay if he has anything to say because I missed this the first time.



================
Comment at: libc/test/src/threads/call_once_test.cpp:60
+  __llvm_libc::mtx_lock(&once_func_blocker);
+  __llvm_libc::mtx_unlock(&once_func_blocker);
+}
----------------
Maybe we could assert that `done_count` is 0 before unlocking?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79828/new/

https://reviews.llvm.org/D79828





More information about the libc-commits mailing list