[libc-commits] [PATCH] D79149: [libc] Move implementations of expf and exp2f from the AOR to src/math.

Petr Hosek via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri May 15 00:52:26 PDT 2020


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: ecnelises.

LGTM



================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.h:42
 
-enum Operation {
-  OP_Cos,
-  OP_Sin,
-};
+enum Operation { OP_Cos, OP_Sin, OP_Exp, OP_Exp2 };
 
----------------
This could be `enum class` and we could avoid the `OP_` prefix but this is fine as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79149/new/

https://reviews.llvm.org/D79149





More information about the libc-commits mailing list